This is the mail archive of the
gnats-devel@sources.redhat.com
mailing list for the GNATS project.
Re: PATCH: v4 send-pr --request-id is broken
- To: Yngve Svendsen <yngve dot svendsen at clustra dot com>
- Subject: Re: PATCH: v4 send-pr --request-id is broken
- From: Milan Zamazal <pdm at zamazal dot org>
- Date: 27 May 2001 17:12:32 +0200
- Cc: gnats-devel at sources dot redhat dot com
- References: <5.0.0.25.2.20010515162348.00b68248@mail.trd.clustra.com>
>>>>> "YS" == Yngve Svendsen <yngve.svendsen@clustra.com> writes:
YS> send-pr --request-id is not working in the current v4
YS> CVS. Instead of the intended PR, the default template would be
YS> sent. The following patch fixes this.
I don't understand the patch, could you elaborate, please?
YS> Index: send-pr.sh
YS> ===================================================================
YS> RCS file: /cvs/gnats/gnats/send-pr/send-pr.sh,v
YS> retrieving revision 1.16
YS> diff -u -p -r1.16 send-pr.sh
YS> --- send-pr.sh 2001/04/08 18:28:25 1.16
YS> +++ send-pr.sh 2001/05/15 14:29:29
YS> @@ -432,16 +432,16 @@ fi
YS> # TEMP is the PR that we are editing. When we're done, REF will contain
YS> # the final PR to be sent.
YS> -while [ -z "$REQUEST_ID" ]; do
YS> - CNT=0
YS> +#
YS> +# Remove comments.
YS> +#
YS> +echo '/^SEND-PR:/d' >> $FIXFIL
YS> +sed -f $FIXFIL $TEMP > $REF
YS> - #
YS> - # Remove comments.
YS> - #
YS> - echo '/^SEND-PR:/d' >> $FIXFIL
YS> - sed -f $FIXFIL $TEMP > $REF
YS> +# REF now has the actual PR that we want to send.
YS> - # REF now has the actual PR that we want to send.
YS> +while [ -z "$REQUEST_ID" ]; do
YS> + CNT=0
YS> #
YS> # Check that synopsis is not empty.
Regards,
Milan Zamazal
--
_/_\_/_ o _\_/_\_ o _/_\_/_ o _\_/_\_ o BEWARE!
-<_|_|_|_><-- -<_|_|_|_><-- -<_|_|_|_><-- -<_|_|_|_><-- *Bugs* are
/ \ / o \ / \ o / \ / o \ / \ o approaching!